Skip to content

Commit

Permalink
correct grammatical and spelling errors
Browse files Browse the repository at this point in the history
  • Loading branch information
ystaticy committed Sep 20, 2024
1 parent a83f127 commit 1b86eae
Showing 1 changed file with 20 additions and 22 deletions.
42 changes: 20 additions & 22 deletions text/0113-keyspace-level-gc.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,35 +10,33 @@ TiKV support [keyspace][1] level GC (garbage collection).
## Concepts of GC management type

1. Global GC:
- Represents the previous default GC logic; there is a TiDB calculate the global GC safe point for the whole cluster.
- The default GC management type for keyspace is Global GC.
2. Keyspace level GC:
- Indicates that the keyspace will advance its own GC safe point.
- Keyspace GC-related data: min start ts, GC safe point, service safe point, stored in own etcd path of each keyspace in PD.
- It represents the previous default GC logic, where TiDB calculates the global GC safe point for the entire cluster.
- The default GC management type for keyspace is the Global GC.
2. Keyspace Level GC:
- It indicates that the keyspace will advance its own GC safe point.
- Keyspace GC-related data includes: minimum start timestamp, GC safe point, service safe point, which are stored in the respective etcd path of each keyspace in PD.

## Motivation

In order to support multi-tenant deployment of TiDB in a shared TiKV cluster, TiDB now supports keyspace feature. A global TiDB GC worker (A TiDB server without Keyspace configuration) shared by all TiDB is in charge of calculating the global GC safe point and resolving locks, while each keyspace's TiDB has their own GC Worker. The GC Worker of each keyspace use the global GC safe point to do "delete-range" in its keyspace ranges.
In order to facilitate multi-tenant deployment of TiDB in a shared TiKV cluster, TiDB now supports the keyspace feature. Currently, the TiDB cluster with keyspace can only utilize the GC calculated by the global GC worker. A global TiDB GC worker (a TiDB server without keyspace configuration) shared by all TiDB instances is responsible for calculating the global GC safe point and resolving locks, while each keyspace's TiDB instance has its own GC worker. The GC worker of each keyspace performs only one operation: utilizing the global GC safe point to execute "delete-range" operations within its keyspace ranges.

But in this implementation the calculation of the global GC safe point depends on the oldest safe point and min start ts of tidb clusters with no keyspace set and all clusters with keyspace set. When any safe point and min start ts are blocked, GC of all TiDB clusters will be blocked.
However, in this implementation, the calculation of the global GC safe point depends on the oldest timestamp (minStartTS, service safe point, etc.) used to calculate the GC safepoint of all TiDB clusters (including those with keyspace configured and those without keyspace configured). When any factor affecting the GC safepoint is blocked, the GC of all TiDB clusters will be blocked.

So we propose the **Keyspace Level GC**:
Therefore, we propose the **Keyspace Level GC**:

TiDB side:
Isolate of GC safe point calculations between keyspaces (the concept is 'keyspace level GC').
It will not affect other keyspaces GC safe point calculation.
Keyspaces can be created by setting `gc_management_type = keyspace_level_gc` to enable keyspace level GC, then this keyspace can calculate GC safe point by itself.
TiDB Side:
Isolate the GC safe point calculations and the storage of related data between keyspaces (the concept is `keyspace level GC`). This will not affect the GC safe point calculations of other keyspaces. Keyspaces can be created by setting `gc_management_type = keyspace_level_gc` to enable keyspace level GC. Then, this keyspace can calculate its own GC safe point.

TiKV side:
In GC process, it parses the keyspace id from the data key, use the keyspace meta config and the keyspace level GC safe point corresponding to the keyspace id to determine the GC safe point value of the data key and execute the GC logic.
TiKV Side:
In the GC process, it parses the keyspace ID from the data key, uses the keyspace meta config and the keyspace-level GC safe point corresponding to the keyspace ID to determine the GC safe point value of the data key and execute the GC logic.

## Implementation in TiKV

1. Get [keyspace meta](https://github.com/pingcap/kvproto/blob/d9297553c9009f569eaf4350f68a908f7811ee55/proto/keyspacepb.proto#L26C1-L33C2) and keyspace level GC safe point from PD:
- Create a keyspace meta watch service: Watch keyspace meta etcd path to get the keyspace meta and put it in the mapping from keyspace id to keyspace meta.
- Create a keyspace level GC watch service: Watch the corresponding etcd path to get the GC safe point of keyspace, put it in the mapping from keyspace id to keyspace level GC safe point.
1. Get [keyspace metadata](https://github.com/pingcap/kvproto/blob/d9297553c9009f569eaf4350f68a908f7811ee55/proto/keyspacepb.proto#L26C1-L33C2) and keyspace-level GC safe points from PD:
- Create a keyspace metadata watch service: Watch the keyspace metadata etcd path to get the keyspace metadata and store it in the mapping from keyspace ID to keyspace metadata.
- Create a keyspace level GC watch service: Watch the corresponding etcd path to get the GC safe point for the keyspace and store it in the mapping from keyspace ID to keyspace level GC safe point.

2. How to get GC safe point by mvcc key in Compaction Filter:
2. How to get the GC safe point after getting the MVCC key in the Compaction Filter:
![img.png](../media/keyspace-level-gc-get-gc-safe-point.png)

3. How to determine if a keyspace uses a keyspace level GC safe point:
Expand All @@ -47,13 +45,13 @@ In GC process, it parses the keyspace id from the data key, use the keyspace met
4. Use GC safe point to optimize trigger timing and assert judgment:
1. In the global GC, it will skip GC when GC safe point is `0` in `create_compaction_filter`.
After supporting keyspace level GC, GC is skipped if global GC safe point is 0 or if no keyspace level GC is initialized.
2. In the global GC, `check_need_gc` function return false in `create_compaction_filter.`
After supporting keyspace level GC, if `props.min_ts` > global GC safe point and `props.min_ts` > all keyspace level GC safe point will return false.
2. In the global GC, `check_need_gc` will skip GC in the compaction filter when `props.min_ts` is greater than all GC safe points.
After implementing keyspace level GC, if `props.min_ts` is greater than the global GC safe point and `props.min_ts` is greater than all keyspace level GC safe points, it will return false.
3. In the global GC, assert( safe_point > 0 ) when new compaction filter.
After supporting keyspace level GC, the assert condition is whether global GC safe point > 0 or any keyspace level GC safe point has been initialized.

5. Support using keyspace level GC for data import and export:
1. When using BR, CDC, Lightning, Dumpling to import or export keyspace data, you need to update the service safe point for the specified keyspace. When the task starts, it needs to get keyspace meta first to determine whehter global or keyspace GC is using, then execute the GC relevant logic on the corresponding GC safe point and service safe point.
5. Support the use of keyspace level GC for data import and export:
- When using BR, CDC, Lightning, or Dumpling to import or export keyspace data, you need to update the service safe point for the specified keyspace. When the task starts, it needs to get the keyspace metadata first to determine whether global or keyspace GC is being used, and then execute the relevant GC logic on the corresponding GC safe point and service safe point.

## Global Backup

Expand Down

0 comments on commit 1b86eae

Please sign in to comment.