Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: add rfc for quota limiters. #99

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

RFC: add rfc for quota limiters. #99

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 53 additions & 0 deletions text/0099-quota-limiter.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
# Quota limiter

- RFC PR: [https://github.com/tikv/rfcs/pull/99](https://github.com/tikv/rfcs/pull/99)
- Tracking Issue: [https://github.com/tikv/tikv/issues/12131](https://github.com/tikv/tikv/issues/12131)
[https://github.com/tikv/tikv/issues/12503](https://github.com/tikv/tikv/issues/12503)

## Summary

Add a global throttle to limit read/write requests, which brings stable QPS.

## Motivation

On the machines where physical resources are constrained, the performance of TiKV may become unstable. Front-end and back-end processing interfere with each other. For example, TiKV's processing of background sampling will take up a lot of CPU processing time, which will cause other requests to be processed with less cpu resource. In addition, under long-term high load pressure, TiKV will accumulate more and more background tasks, such as compaction jobs, etc. When resources are limited and users are not sensitive to performance, it's better for TiKV to work stably under high pressure.

## Detailed design

### Limited method

This feature plans to add multiple global limiters into TiKV to record different types of processing speed. These types include CPU time, read/write bandwidth.

When the limiter reaches the quota value, the request will be forced to block for a period of time to compensate, based on the result returned from a speed limiter using the token bucket algorithm.

Several new configs will be added. Users need to limit each metric separately, of which the quota for cpu time is an approximate value.

* quota.foreground-cpu-time: usize
* quota.foreground-write-bandwidth: ReadableSize
* quota.foreground-read-bandwidth: ReadableSize
* quota.background-cpu-time: usize
* quota.background-write-bandwidth: ReadableSize
* quota.background-read-bandwidth: ReadableSize
* quota.max-delay-duration: ReadableDuration
* quota.enable-auto-tune: bool

We separate the quota configuration of foreground and background requests. `max-delay-duration` is used to specify the ceiling of penalty.
And if `quota.enable-auto-tune` is on, quota can be adjusted according runtime workload of the TiKV instance.

### Limited position

Clock and limit at the location of code blocks for the above metric that will significantly affect.

**scheduler write:** All txn write requests will be handled in the `process_write` function.

**tidb query executor:** Coprocessor DAG processing will be handled in `BatchExecutorsRunner`.

**txn get:** Get value processing will be handled in `storage::get`

**txn batch get:** Get multiple value processing will be handled in `storage::batch_get`

**analyze request:** Coprocessor analyze processing will be handled in `collect_columns_stats`.

## Drawbacks

Setting a quota that is too small may cause significant performance degradation, which requires experienced users to config the quota.