Support IMDSv2 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ping Yu <[email protected]>
Signed-off-by: Ping Yu <[email protected]>
Signed-off-by: Ping Yu <[email protected]>
Signed-off-by: Ping Yu <[email protected]>
Signed-off-by: Ping Yu <[email protected]>
Signed-off-by: Ping Yu <[email protected]>
coocood
approved these changes
Jun 7, 2024
pingyu
added a commit
to pingyu/rusoto
that referenced
this pull request
Jun 7, 2024
Signed-off-by: Ping Yu <[email protected]>
pingyu
added a commit
to pingyu/rusoto
that referenced
this pull request
Aug 8, 2024
Signed-off-by: Ping Yu <[email protected]> Signed-off-by: Ping Yu <[email protected]>
pingyu
added a commit
that referenced
this pull request
Aug 8, 2024
* Support IMDSv2 (#5) Signed-off-by: Ping Yu <[email protected]> Signed-off-by: Ping Yu <[email protected]> * Apply suggestions from code review Signed-off-by: Ping Yu <[email protected]> Co-authored-by: kennytm <[email protected]> Signed-off-by: Ping Yu <[email protected]> --------- Signed-off-by: Ping Yu <[email protected]> Signed-off-by: Ping Yu <[email protected]> Co-authored-by: kennytm <[email protected]>
9 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please help keep the CHANGELOG up to date by providing a one sentence summary of your change:
Access to S3 meet the following on an EC2 instance with IAM role having permission of S3 actions:
[2024/06/05 07:57:52.996 +00:00] [WARN] [util.rs:90] ["aws request meet error."] [uuid=10ed33a3-a245-40d0-b4ff-40bf02b8c7dc] [context=get_cred_on_premise] [retry?=true] [err="Couldn't find AWS credentials in environment, credentials file, or IAM role;No (or empty) AWS_ACCESS_KEY_ID in environment;Couldn't stat credentials file: [ \"/home/ec2-user/.aws/credentials\" ]. Non existant, or no permission.;Could not get request from environment: Neither environment variable 'AWS_CONTAINER_CREDENTIALS_FULL_URI' nor 'AWS_CONTAINER_CREDENTIALS_RELATIVE_URI' is set;Could not get credentials from iam: invalid uri character"]There are 2 issues:
invalid uri charactorwas misleadering. Thesecurity-credentialsAPI actually returned the 401 error, but we do not check the status code, and consider error message as role name:IMDSv2.In this PR:
IMDSv2.Manual Test