-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebase the TiKV branch on to master #3
Conversation
…-temperatures Add specific path to get raspberry pi CPU temperature
Greatly improve windows performance
…rsion Update crate version
…rovements Windows improvements
…perature Windows temperature
Fix error with networks and total outcome on Linux
Update crate version
Document how to cross compile with proper Cargo configuration
… if it isn't listed yet
…resh-process Enforce refresh process
Fix ProcessExt::kill on windows
Update crate version to 0.11.2
Signed-off-by: Lonng <[email protected]>
Signed-off-by: Lonng <[email protected]>
Signed-off-by: Lonng <[email protected]>
Signed-off-by: Lonng <[email protected]>
Signed-off-by: Lonng <[email protected]>
Hi, @nrc Can we move some changes which cannot be merged to upstream to an individual repository? And use upstream |
For information: I intend to add I/O information at some point. But in the meantime, you'll have to continue using your own code. |
Signed-off-by: Nick Cameron <[email protected]>
We could, but I think not now - this PR is an improvement on the current situation, and the better long-term solution is to upstream everything. If that is not possible (I think it should be), then we can make another repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is now https://github.com/tikv/sysinfo/tree/tikv2 |
So, some of our changes got upstreamed, but did not (in particular, io and mem load). So rather than use the old tikv branch, I rebased it to current sysinfo master. I've removed some code which has alternatives in upstream. I think that we can work to upstream the other stuff, but in the meantime I need something so I can run TiKV tests on my machine.
Unfortunately, since this is a rebase, it cannot be merged with the tikv branch. If this PR passes review I propose we create a new branch, tikv2 or something, to land it rather than merging this PR into our master.
PTAL @lonng