Fix invalid version string for precompiled builds

tilotech · Jan 30, 2023 · ebf1ebb · ebf1ebb
1 parent 301c1cf
commit ebf1ebb
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/.goreleaser.yml b/.goreleaser.yml
@@ -20,7 +20,7 @@ builds:
     main: ./
     flags:
       - -trimpath
-    ldflags: -s -w -X main.version={{.Version}} -X main.commit={{.ShortCommit}} -X main.date={{.Date}}
+    ldflags: -s -w -X main.version={{.Version}}
 
 archives:
   - format: tar.gz

diff --git a/cmd/version.go b/cmd/version.go
@@ -27,12 +27,18 @@ func init() {
 	rootCmd.AddCommand(versionCmd)
 }
 
+// Version will hold the actual build version from main for precompiled binaries.
+var Version = ""
+
 func printVersion() error {
 	buildInfo, ok := debug.ReadBuildInfo()
 	if !ok {
 		return fmt.Errorf("could not read BuildInfo")
 	}
-	version := buildInfo.Main.Version
+	version := Version
+	if version == "" {
+		version = buildInfo.Main.Version
+	}
 	if version == "" {
 		version = "development"
 	}

diff --git a/main.go b/main.go
@@ -2,6 +2,9 @@ package main
 
 import "github.com/tilotech/batch-graphql/cmd"
 
+var version = ""
+
 func main() {
+	cmd.Version = version
 	cmd.Execute()
 }