Skip to content

Conversation

@waspeer
Copy link

@waspeer waspeer commented Jan 11, 2021

I bumped into a problem where when passing Infinity as an value for the retries option, it will result into a memory heap overload when it tries to create the array of timeouts. It seems like this option is supposed to be supported. This PR is my proposition on how this could be fixed.

@codecov
Copy link

codecov bot commented Jan 11, 2021

Codecov Report

Merging #77 (1017a56) into master (a7cedfb) will decrease coverage by 1.74%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
- Coverage   90.41%   88.66%   -1.75%     
==========================================
  Files           2        2              
  Lines         146      150       +4     
==========================================
+ Hits          132      133       +1     
- Misses         14       17       +3     
Impacted Files Coverage Δ
lib/retry.js 96.29% <100.00%> (-1.71%) ⬇️
lib/retry_operation.js 84.37% <0.00%> (-2.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7cedfb...1017a56. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant