Make platform HTTP write timeout unbounded and configurable - #121
Merged
Conversation
Large platform uploads were dying on httpx.WriteTimeout after 10s because Timeout(10, read=None) still capped write. Default write/read to unbounded, add TIMBAL_HTTP_*_TIMEOUT env knobs, and surface timeouts as PlatformError with the phase + knob to raise. Co-authored-by: Cursor <cursoragent@cursor.com>
selormwalker
reviewed
Aug 7, 2026
selormwalker
left a comment
selormwalker
left a comment
There was a problem hiding this comment.
Nice improvements! Ready for merging.
pedrolivaresanchez
approved these changes
Aug 7, 2026
selormwalker
reviewed
Aug 7, 2026
selormwalker
left a comment
selormwalker
left a comment
There was a problem hiding this comment.
Great work on this pull request. Tested and verified changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Timeout(10, read=None)).TIMBAL_HTTP_TIMEOUT,TIMBAL_HTTP_WRITE_TIMEOUT,TIMBAL_HTTP_READ_TIMEOUT(none= unbounded).PlatformErrorwith phase + env knob hint instead of a bareWriteTimeout.Test plan
pytest python/tests/platform/test_platform_utils.py(52 passed)TIMBAL_HTTP_WRITE_TIMEOUT=10restores the old write capMade with Cursor