Merge pull request #156 from times-yasunori/improve-from-slack-text

POST /awesome/from-slack-text で body がなければ空のテンプレートを返すようにする
times-yasunori · Nov 6, 2024 · b9d220e · b9d220e
2 parents 9efb143 + 3b53141
commit b9d220e
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 15 deletions.
diff --git a/packages/api/src/index.test.ts b/packages/api/src/index.test.ts
@@ -83,7 +83,7 @@ describe("Test GET /awesome/random", () => {
   });
 });
 
-describe("Test GET /awesome/random", () => {
+describe("Test GET /awesome/:id", () => {
   test("Should return 200 response", async () => {
     const res = await app.request("/awesome/1");
     expect(res.status).toBe(200);
@@ -137,11 +137,12 @@ describe("Test POST /awesome/from-slack-text", () => {
 yasuhara`,
     });
     const parsed = await res.text();
+    const today = new Date().toISOString().split("T").at(0);
     const [header, id, ...rest] = parsed.split("\n");
     expect(header).toStrictEqual("[[yasunori]]");
     expect(id).toMatch("id = "); // いまのテスト環境だとidが変化するため値のテストはできない
     expect(rest.join("\n")).toStrictEqual(`title = "えっ、yasunori 知らないの？"
-date = "2024-11-02"
+date = "${today}"
 at = "vim-jp #times-yasunori"
 senpan = "tomoya"
 content = """
@@ -154,17 +155,24 @@ meta = """
 `);
   });
 
-  test("Should return 404 error response if entry not found", async () => {
-    const res = await app.request("/awesome/0");
-    expect(res.status).toBe(404);
-    expect(await res.json()).toStrictEqual({ errors: ["not found"] });
-  });
-
-  test("Should return 404 error response if params is not number", async () => {
-    const res = await app.request("/awesome/id");
-    expect(res.status).toBe(404);
-    expect(await res.json()).toMatchObject({
-      errors: [{ type: "safe_integer" }],
+  test("Should return blank YA toml response", async () => {
+    const res = await app.request("/awesome/from-slack-text", {
+      method: "POST",
     });
+    const parsed = await res.text();
+    const today = new Date().toISOString().split("T").at(0);
+    const [header, id, ...rest] = parsed.split("\n");
+    expect(header).toStrictEqual("[[yasunori]]");
+    expect(id).toMatch("id = "); // いまのテスト環境だとidが変化するため値のテストはできない
+    expect(rest.join("\n")).toStrictEqual(`title = ""
+date = "${today}"
+at = "vim-jp #times-yasunori"
+senpan = ""
+content = """
+
+"""
+meta = """
+"""
+`);
   });
 });
diff --git a/packages/api/src/index.ts b/packages/api/src/index.ts
@@ -69,9 +69,9 @@ const route = app
     }
     const id = latestEntry.id + 1;
     const lines = slackText.split("\n");
-    const [senpan, , title, ...restContents] = lines;
+    const [senpan, , title = "", ...restContents] = lines;
     const date = new Date().toISOString().split("T").at(0);
-    const content = `${title}\n${restContents.join("\n")}`;
+    const content = title ? `${title}\n${restContents.join("\n")}` : "";
     const tomlString = `[[yasunori]]\nid = ${id}\ntitle = "${title}"\ndate = "${date}"\nat = "vim-jp #times-yasunori"\nsenpan = "${senpan}"\ncontent = """\n${content}\n"""\nmeta = """\n"""\n`;
     return c.text(tomlString);
   })