hono clientをapiに移す #169
Merged
hono clientをapiに移す #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ryoppippi
commented
Dec 30, 2024
ryoppippi
commented
- hono clientをapi側に移しました
- hono をwebの依存関係から削除しました
tomoya
reviewed
Dec 30, 2024
| import { hc } from "hono/client"; | ||
|
|
||
| export const yasunoriApiClient = hc<ApiRoute>("https://api.yasunori.dev"); | ||
| export * from "@awesome-yasunori/api/src/client"; |
There was a problem hiding this comment.
api パッケージから export するなら、 import パスに src が含まれているのも解決しておきたいですね。
There was a problem hiding this comment.
ありがとうございます
- web内のtsconfigでaliasを追加して解決する
- api側でpackage.jsonにexports fieldを追加する（その場合api側の事前ビルドが必要）
のどちらが良いですか？
There was a problem hiding this comment.
exports fieldも、ts fileそのまま指定で良いのであればビルド必要なさそうですね
☝️の方法でも良いですか?
There was a problem hiding this comment.
@tomoya
exports filedを追加しました
|
@tomoya よろしくお願いします！ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.