This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
charts/timescaledb-single: add imagePullSecrets #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to values.yml
to statefulset-timescaledb.yaml for the StatefulSet
|
Any chance this will make it in the next release? Currently I have to run a local version of this chart only because of this change. |
paulfantom
suggested changes
Apr 29, 2022
| @@ -41,6 +41,10 @@ spec: | |||
| runAsGroup: {{ template "postgres.uid" }} | |||
| runAsNonRoot: true | |||
| runAsUser: {{ template "postgres.uid" }} | |||
| {{- if .Values.imagePullSecrets }} | |||
There was a problem hiding this comment.
Please add the field in values.yaml and schema files.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a private repository was not possible before, so I added the imagePullSecrets to the StatefulSet.
You can now define an existing secret from the same namespace. Example:
Checkout https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry/ for detailed information.