Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MetricSummary::bounds cleanup #390

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

MetricSummary::bounds cleanup #390

wants to merge 2 commits into from

Commits on Apr 14, 2022

  1. Add bounds tests documenting existing behavior.

    @epgts
    epgts committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    405233d View commit details
    Browse the repository at this point in the history

  2. MetricSummary::bounds cleanup 

    MetricSummary:
- Delegate to I64Range for infinity rather than duplicating the concept.

I64Range
- Cleanup and encapsulate I64Range's handling of infinite bounds.
- Enforce validity in new factory functions `empty` and `infinite`.
  (method `extend` already did)
- Expose #[inline] left and right methods.
- Privatize left and right fields.
- Factor out new method `both` out of various places that needed access
  to finite left and right.

Closes issue #386.
    @epgts
    epgts committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    8c1ab3b View commit details
    Browse the repository at this point in the history