Upgrade to pgrx 0.12.8 and add PostgreSQL 17 support #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sebastian Webber <[email protected]> Signed-off-by: Vinh <[email protected]>
…lkit into pg17-support
WIP: Pg17
This container is built in CI with the current release, so use that one when testing.
issue with auto-generated functions) and more
zilder
force-pushed
the
zilder/pgrx_0.12.7
branch
from
5d062c4
to
74a96a9
Compare
|
Thank you so much for handling this! |
syvb
reviewed
Nov 4, 2024
bors.toml
Outdated
| @@ -1,17 +1,19 @@ | |||
| status = [ | |||
There was a problem hiding this comment.
We don't use bors anymore; this whole file can be removed.
JamesGuthrie
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #820. Fixes compilation issues that came with pgrx 0.12.*.
Major changes:
pg_externmacro expansion anymore. So allpg_externfunctions' return types now have to explicitly use `'static' lifetime._outfunctions inPostgresTypemacro do not work (do not compile) because they get their return type annotated with rust type's lifetime ('inputin our case). (This may actually be a bug and should probably be addressedpgrx.) For this reason I added default implementation for_in/_outfunctions, as well as ArgAbi and BoxRet (it seems to be a package deal when you implement custom in/out functions)Minor things:
PostgresTypenow requires a type to implementSerializable/Deserializabletraits. As far as I understand they are used for default implementation ofIntoDatum/FromDatum. Toolkit has its own implementation for these so ser/de aren't really needed. Also the default implementation ofDeserializablehas some conflicts with type's lifetime, so I added a trivial implementation and putunimplemented!()there as it isn't used anyway. If anyone has a better solution, pls let me know.BoxRetimplementation that is now also required byPostgresType(I just copied the one that pgrx uses for a bunch of predefined types).NodeTagis now anenumhence manyconst => enumreplacements.pg_externobjects that is) in toolkit haven't been set up properly causing incorrect order of DDL commands in the installation script.