Prevent bug if document.createEvent fails but window.addEventListener does not #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't assume that window.addEventListener capability gives us the document.createEvent capability. (Some IE shims, like aight.js, only define the former and not the latter. In this case, timesheets.js assumes that the browser is modern and then encounters a javascript error when it tries to execute document.createEvent.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some IE8 shims will provide certain capabilities and not others. In these capability checks, you're looking for
window.addEventListenerand then assuming that its existence will automatically give you the existence ofdocument.createEvent. In the case where you are using both, I am explicitly checking for the existence of both.I'm not sure if this project is being actively manned, but let me know if there's anything you want in order to merge. I used
jsminto create the.min.jsfiles.