Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: extract DataFrame conversion #127

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

client: extract DataFrame conversion #127

wants to merge 3 commits into from

Commits on Jan 6, 2021

  1. client: check if column exists before converting 

    Check if the column exists in the dataframe prior to accessing it for
conversion.

Fixes timkpaine#121
    @jkoelker
    jkoelker committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    5962068 View commit details
    Browse the repository at this point in the history

  2. client: coerce columns to numeric 

    The greeks and `volatility` columns will sometimes come back with the
string `NaN` which results in an `object` dtype for the column. Force to
a numeric with coercing errors to insert `numpy.NaN` instead.
    @jkoelker
    jkoelker committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    ac17b2a View commit details
    Browse the repository at this point in the history

  3. client: extract DataFrame conversion 

    Extract the `DataFrame` conversion into a module of helper functions.
    @jkoelker
    jkoelker committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    95f5a42 View commit details
    Browse the repository at this point in the history