-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add test support #52
base: master
Are you sure you want to change the base?
feat: Add test support #52
Conversation
Since `vscode` `1.0.0` and Code (the editor itself) `1.6.1` extensions generated by the Yeoman generator use typescript `2.0.3`. This commit migrates the extension following the instructions provided here: https://code.visualstudio.com/updates/v1_6#_extension-authoring
@fahrradflucht This looks nice and I would like to pull this in. But have you tested this on Windows? As you can see in elixirServer, launching processes from within node (used?) to require some extra handling for windows. |
No I have not. And sadly I don't have the possibility to do it easily. FWIW IIRC the problem on windows is primarily if you have spaces in the command elements. This should be no problem here. Edit 1: Edit 2: |
I will check this on windows once I find the time (and nerve ;) ) to boot into it. I would like to add your tslint configuration as well. Style looks good to me 👍 Could you add that to the PR? |
Hmpf I tested it on a Windows 8.1 32bit virtual machine and it is broken 😞 . |
@fahrradflucht: Got a chance to work on this yet? |
Sadly no. Can't motivate myself to fix these Windows issues. But I think after this: http://code.visualstudio.com/updates/v1_11#_tasks we should rethink the feature design from the ground up anyway. |
@fr1zle would it be possible to get this into the extension without Windows support and have that be a TODO? |
This PR adds support for test execution in an output pane. The commands provided are:
Elixir: Test Project
Elixir: Run Current Test File
Elixir: Run Test at Cursor
Elixir: Re-run last test
I think what they do is pretty self explanatory. Sadly currently the output panes have no syntax highlighting.
Please don't feel forced to pull this into the extension if you think this isn't in the scope of the project. In addition to that I would love feedback if you think the way the tests are integrated is handy or not.
If this high-level checks are out of the way please review. 😃
There aren't any tests for my code which is sad but I didn't came up with a good way to test this. I have to think about this some more.
NOTE: I updated the extension to newer versions of the vscode library and typescript. Let me know if this is a problem.
Sidenote: I used
tslint
with some basic rules for my new code but I neither commited thetslint.json
not did update the old code. Let me know if you think we should adopt it in some form for the whole project.