Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not to be merged, these are for @danyshaanan. What I am thinking would be convenient is a decimalAlign: 'left/center/right' that only gets applied to 'mostly numeric' columns. The way it works is, if this option is specified, detect whether or not its a numeric column, then if it is, basically the behavior from the
align-dots
module or something similar gets applied to those columns, and then run the indicated regular alignment after you get that decimal aligned output. I was thinking at first of just trying to make it where decimals were aligned and then the padding spaces go to the left (so always aligned to the right) but I think there are cases where after decimal aligning it really needs to be in the left or center rather than the right to go along with people's other formatting.The example has the first column 'PACKAGE' that has a version number in it, my thought was to just try a standard 'isNumeric' and if its not then the decimalAlign option doesn't apply to that column (so it doesn't just look for period characters). This of course applies to when it is used as a global.