-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various setup.sh fixes #74
base: master
Are you sure you want to change the base?
Conversation
* Was failing in a new environment * Added in lines to copy over 'test' config files into production * Added in lines to copy existing production config files when redeploying
@@ -45,7 +45,7 @@ third_party: | |||
|
|||
src/pip-delete-this-directory.txt: requirements.txt | |||
$(ACTIVATE) && pip install -r requirements.txt | |||
$(ACTIVATE) && [ -f private/requirements.txt ] && pip install -r private/requirements.txt | |||
#$(ACTIVATE) && [ -f private/requirements.txt ] && pip install -r private/requirements.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is needed for deployment. You put your postgressql requirements, etc in the private/requirements file.
Why did you remove it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, let me fix that; it was barfing entirely on my machine, causing the whole thing to fall over. Forgot to go back and debug that beyond commenting it out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mithro This is now fixed. Needed || exit 0 added (if file didn't exist, would throw an error, bash would exit)
* /usr/local/var on some systems is chmod 700
* Required for non-dvswitch ALSA sources
* Documentation re 'make distclean' if install fails * Revert Makefile to include private/requirements.txt as per Tim request
* Missing 'make serve' > 'make testserve'
* Added || exit 0, was causing setup.sh to die if file did not exist
This is now ready for review. Apologies for all the commits. |
poke @mithro |
Unlikely I'll get to reviewing this until the weekend or early next week. On 10 August 2014 20:19, Ryan Verner [email protected] wrote:
|
@xfxf (hope this works here) I have some pending changes too: Have you touched Vagrant ? once you have vagrant apt-get installed, wget http//github..../vagrantfile; but it does't play well with user interaction, like "enter hostname for On Sun, Aug 10, 2014 at 5:19 AM, Ryan Verner [email protected]
Carl K |
Hi @ryanverner I can't merge this pull request anymore. Can you rebase and update this pull request? |
@@ -20,6 +20,12 @@ viewing sides. | |||
It has been used with conferences like PyCon US and Linux.conf.au and at user | |||
groups like Sydney Linux User Group and Sydney Python User Group. | |||
|
|||
# Important information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is in the correct location.
Maybe move it under the # Parts
section and make it a subheading.
|
||
```python register_wrapper.py -m user:password@encoder-server -g group -s sharedsecret``` | ||
|
||
(where: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't need a "(" here...
@xfxf When you get a moment, we should look at this pull request and figure out what we need to merge here. |
@xfxf Since you might have time now, can you take another look at this? |
This was failing on a brand new installation (worked fine for redeploying where it had already been used). Some fixes. Works here now on a brand new Ubuntu 12.04 install.