Added new type of button: ModalButton - opens specified Modal #1890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bradystroud
force-pushed
the
actionsButtonUpdate
branch
from
d8dd3e4
to
a4816e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1879 we wanted to ensure that buttons on the home-page COULD act the same as the buttons in the navigation bar - in this case we wanted component to be able to open modals as well as open links.
This PR modifies the actions template allowing users to pick from three options: [ModalButton, LinkButton, CodeButton] in the new ButtonType field. There is also an option selector for the available modals which a user can chose from
Update:
After a conversation with @bradystroud for future proofing the UX, we have created 3 seperate components for each of the buttons. Now every single time we referenced the actions component we instead get the option of different buttons to click/ use.
This being the actions button, modal button or code button. This can easily be added to with future types of buttons.
I have gone through all other pages and components and fixed where necessary.
Figure: ✨OUTDATED Modifications to Actions Template
Figure: 💄 Buttons Section
Figure: 💄Button Options