Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ’„ Docs – Product Tour Pagination Styling #2660

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

isaaclombardssw
Copy link
Contributor

@isaaclombardssw isaaclombardssw commented Dec 24, 2024

Desc.

From Adam's email...

  1. Getting Started - bug ⚠️

Screenshots

image
Figure – Before

SCR-20241224-kfry

Figure – After

General Contributing:

All New Content Submissions: (To be confirmed by reviewer)

  • Title is short & specific
  • Headers are logically ordered & consistent
  • Purpose of document is explained in the first paragraph
  • Procedures are tested and work
  • Any technical concepts are explained or linked to
  • Document follows structure from templates
  • All links work
  • The spelling and grammar checker has been run
  • Graphics and images are clear and useful
  • Any prerequisites and next steps are defined.

Copy link

vercel bot commented Dec 24, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
tina-io βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Dec 24, 2024 0:16am

@isaaclombardssw isaaclombardssw marked this pull request as ready for review December 24, 2024 00:16
@isaaclombardssw isaaclombardssw requested a review from a team as a code owner December 24, 2024 00:16
<div className="w-1/2">
<DocsPagination prevPage={previousPage} nextPage={nextPage} />
<div className="w-full">
<DocsPagination prevPage={null} nextPage={nextPage} />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why're we setting this to null by default?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants