-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create UI library module #118
Conversation
I would suggest a more unique name for the library, such as |
That's fine @or-else |
How about naming everything |
I think it's good. |
|
@@ -26,7 +26,7 @@ public Dialog onCreateDialog(Bundle savedInstanceState) { | |||
} | |||
|
|||
AlertDialog.Builder builder = new AlertDialog.Builder(activity); | |||
View dialog = View.inflate(activity, R.layout.dialog_about, null); | |||
View dialog = View.inflate(activity, R.layout.tindroid_dialog_about, null); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no need for prefixes in the app. The prefixes should be used only in the libraries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's right, I did this just to make the search/replace easier for me.
I'll remove the prefix once I have finish.
@or-else Currently a lot of features are tightly coupled with the application like (Contacts sync, Chats lists, Messages, etc.) Currently this is what my mind for UI:
|
I'm not concerned with the app being tightly coupled with the SDK and UI libraries. I do not foresee a case where I would want to swap this UI library for another in the app. So, the app is not of concern, the Let's take a step back: what is the intended use case for the |
Exactly this is what I'm trying to achieve. What I understand that not every component will add to |
Great, we agree. I would start with creating components for message bubbles. |
Then contact display. |
This PR seems to be getting stale. Should I close it? |
@or-else I was bit busy last month, but I made some progress creating some views and feed them from |
Thanks for the update. |
@or-else Currently, I'm overwhelmed with changing job process. I'll pause my work in this PR until I settle in the new job. |
Is this still relevant? |
Solve #117