Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add magit faces #60

Merged
merged 1 commit into from
Dec 3, 2017
Merged

Add magit faces #60

merged 1 commit into from
Dec 3, 2017

Conversation

shitikanth
Copy link

@shitikanth shitikanth commented Dec 3, 2017

Before:
screenshot_20171202_215742

After:
screenshot_20171202_215814

This is not an attempt to support all Magit faces. As @belak says in #57, there are complications, especially regarding how to handle diffs since they use different shades of red and green. The goal here is to avoid colors inconsistent with the theme as much as possible (see before pic).

@belak
Copy link
Member

belak commented Dec 3, 2017

I think you may have meant #57. It looks pretty good to me. I also appreciate you providing screenshots. It makes it much easier to see differences and definitely helps speed up getting stuff in.

I'm not complaining, but I'm curious how you picked the colors (it's perfectly valid to say trial and error ;)). I can see (just as an example) that in the top picture names are red but in the bottom, either blue or cyan was used.

@shitikanth
Copy link
Author

@belak
I am not a designer, so I wouldn't have a much better answer than I picked the colors that I liked and changed the ones I didn't.

For instance, in this particular case, red was too attention-grabbing for my eyes and it was stopping from focusing on the commit messages itself, so I decided to choose a more neutral colour.

@belak
Copy link
Member

belak commented Dec 3, 2017

That works for me. :) Thanks for your contribution!

@belak belak merged commit f6806b1 into tinted-theming:master Dec 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants