Skip to content

Conversation

zacharyweiss
Copy link
Contributor

@zacharyweiss zacharyweiss commented Jun 11, 2025

Howdy!

This PR adds Neal McKee's fantastic Penumbra theme. Two things I want input on prior to merge:

  1. Credit: Neal welcomes ports and the theme is MIT licensed. In this repo, it appears as though the "author" field is meant to indicate "maintainer" (/ "author of the yaml"), hence listing myself, but I don't wish to claim credit for the palette itself. I've added the source to the README and per-theme descriptions; is there a more appropriate way to do this? @nealmckee: if you see this, any input / preferences?
  2. Naming: upstream, the contrast variants are labeled "contrast+" and "contrast++". Your home repo and other PRs here seems to indicate the yaml name should match the slugified name field; I changed these variants to "Contrast Plus" and "Contrast Plus Plus" to conform. However this feels quite clunky/lengthy to me; any better alternative?

@zacharyweiss zacharyweiss changed the title Add base16 Penumbra {Light,Dark} {,Contrast Plus,Contrast Plus Plus} theme Add base16 Penumbra themes Jun 11, 2025
@zacharyweiss zacharyweiss marked this pull request as ready for review June 23, 2025 18:28
@zacharyweiss zacharyweiss requested a review from a team as a code owner June 23, 2025 18:28
@zacharyweiss zacharyweiss requested review from JamyGolden and FredHappyface and removed request for a team June 23, 2025 18:28
Copy link
Member

@JamyGolden JamyGolden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@JamyGolden JamyGolden merged commit 5a775c6 into tinted-theming:spec-0.11 Jun 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants