linux (gap): improve error information #388
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gen2thomas
force-pushed
the
feature/improved_errors
branch
from
e6f5f05 to
c3cdc9d
Compare
gen2thomas
commented
Oct 6, 2025
| changes := sig.Body[1].(map[string]dbus.Variant) | ||
| if connected, ok := changes["Connected"].Value().(bool); ok && connected { | ||
| close(connectChan) | ||
| errChan <- nil |
There was a problem hiding this comment.
Suggested change
| errChan <- nil |
most likely this can be removed, I'm not quite sure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my project involving many different (gobot-) devices, I found it difficult to identify the cause of errors in the start-stop workflow (connect-disconnect-connect), e.g. "Operation already in progress" was returned from this driver. When adding a little bit more information it is more clear which line/action causes the error.
Additionally I replaced the "connectChan" by a channel for the error to be returned from the go-routine. This should prevent possible access conflicts to the err-variable, although it looks to me that the go-routine is not really needed at the moment and could be replaced by a synchronous code - but maybe I overlooked something. A good reason for the go-routine would be, e.g. the implementation of a connect-timeout.