Repository navigation
fix(rp2): misc spinlock-related fixes - #5041
Merged
Merged
Conversation
eliasnaur
reviewed
Sep 16, 2025
mikesmitty
force-pushed
the
ms/disable-dbgpause
branch
from
September 17, 2025 03:10
76af84e to
9db4f8f
Compare
eliasnaur
reviewed
Sep 17, 2025
eliasnaur
left a comment
eliasnaur
left a comment
Contributor
There was a problem hiding this comment.
LGTM, but you probably want to change the PR title to reflect that you're fixing multiple issues.
Contributor
Author
Ah yeah, good point. I ended up adding more things than I planned originally |
mikesmitty
changed the title
Contributor
Author
|
I thought I was done, but here's one more. schedulerLock can stay held through a soft reset, especially if the reset happens while all tasks are sleeping, and since spinlocks don't get reset during a soft reset it will hang the scheduler before |
mikesmitty
force-pushed
the
ms/disable-dbgpause
branch
from
September 17, 2025 21:46
813de30 to
13e41f4
Compare
mikesmitty
force-pushed
the
ms/disable-dbgpause
branch
from
September 18, 2025 11:52
13e41f4 to
fbfdaa5
Compare
Member
|
Thank you for the fixes here @mikesmitty and to @eliasnaur for review. Now merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DBGPAUSE pauses the timer used for sleep pauses when a debugger is attached, which gets annoying to debug. Might be related to https://github.com/tinygo-org/tinygo/blob/v0.39.0/src/runtime/runtime_rp2.go#L314