Skip to content

fix(webhook): give a delivery a deadline, and cover the policy and ACP edges #2212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oxoxDev merged 6 commits into from
Sep 10, 2026
Merged

fix(webhook): give a delivery a deadline, and cover the policy and ACP edges #2212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f6c776b
test(ops/policy): cover AUTH/LIMIT/FAIL axes for company policy handler
oxoxDev Sep 9, 2026
cd6691c
test(acp/transport): drive router() through HTTP for auth/state/bound…
oxoxDev Sep 9, 2026
09b7496
fix(webhook): give a delivery a deadline, and make the wiring assertable
oxoxDev Sep 9, 2026
633bda1
ci: run the webhooks tests, rather than only compiling them
oxoxDev Sep 9, 2026
d7a2953
ci: classify the webhooks lane as filtered, and repair a split rationale
oxoxDev Sep 10, 2026
6c96a89
test(acp): assert which updates a turn emits, not how many
oxoxDev Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1449,6 +1449,14 @@ jobs:
- name: Test (tinyplace)
run: cargo test --locked --features tinyplace --lib

# `webhooks` gates `HttpWebhookSink` and its HMAC signer, and its tests
# were compiled by `Check (--all-features)` and run by nothing. Scoped to
# the module rather than the whole lib: this is a sixth feature
# resolution, and the rest of the suite is already covered by the lanes
# above. `--locked` per issue #251, as for every graph-resolving call.
- name: Test (webhooks)
run: cargo test --locked --features webhooks --lib server::webhook

@chatgpt-codex-connector chatgpt-codex-connector Bot Sep 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Run the webhook lane through the count-checking wrapper

Fresh evidence in this revision is that the filtered webhook lane now exists, but it invokes cargo test directly instead of scripts/ci/run-scoped-suite.sh. If server::webhook is renamed, moved, or gated away, Cargo exits successfully after running zero tests, silently restoring the compile-only coverage gap this lane is intended to close; invoke the wrapper with the same feature and filter so CI asserts a nonzero test count.

AGENTS.md reference: AGENTS.md:L115-L117

Useful? React with 👍 / 👎.


# Issue #1118. The gated host binary the `Console E2E (live brain)` job needs
# is built HERE rather than as the last step of `Rust (openhuman, tinymemory)`
# above, and the move is a wall-clock change, not a tidy-up.
Expand Down
4 changes: 2 additions & 2 deletions scripts/ci/feature-lanes.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ paypal | partial | openhuman,chargebee,paypal,composio | paypal ser
sidecar | partial | sidecar | brain::sidecar
analytics | partial | analytics | analytics
crash-reporting | partial | crash-reporting | observability
webhooks | partial | webhooks | server::webhook

# --- Owed a lane: gated tests exist, and they are currently RED -------------
#
Expand All @@ -93,7 +94,7 @@ crash-reporting | partial | crash-reporting | observability

# --- Compile-only, by design ------------------------------------------------
#
# The shape shared by the six below: the PORT (a trait), its offline mock, and
# The shape shared by the five below: the PORT (a trait), its offline mock, and
# the whole decision flow around it live in the default build and are tested
# there. Only a thin real-network implementation sits behind the feature, and it
# carries no test of its own — there is nothing to run without the network it
Expand All @@ -105,7 +106,6 @@ openhuman-rpc | compile-only | - | Only `HttpOpenHumanRpc` is gated. The trait
github | compile-only | - | Only `HttpGitHubClient` is gated. `GitHubClient`, its mock and the whole issue-filing flow test at default features (src/feedback/github.rs tests sit outside the gated `mod http`).
tinyhumans | compile-only | - | Only `HttpTinyHumansClient` / `HttpHubIdentityExchange` are gated. The trait, mock and routing decision test at default features.
medulla | compile-only | - | Only the HTTP/Socket.IO transport is gated. Wire types + `MockTransport` test at default features; the gated `http` module carries no test.
webhooks | compile-only | - | Only `HttpWebhookSink` / `HmacSha256Signer` are gated. The `WebhookSink` trait, `RecordingWebhookSink` and the deterministic default signer test at default features.
dns | compile-only | - | Only `HickoryDnsResolver` is gated. The `DnsResolver` trait, `StaticDnsResolver` and the pure record generation test at default features.

# --- Compile-only, no gated test exists yet ---------------------------------
Expand Down
Loading
Loading