Reconnect Composio connector sync to the memory tree - #13
The change looks sound. The earlier concern about the untested log-and-continue
The change looks sound. The earlier concern about the untested log-and-continue failure path is resolved: the PR adds tree_ingest_failure_is_tolerated_and_skill_store_is_retained, which forces a genuine tree-ingest failure, verifies store swallows it, and verifies the skill store retains the item. The main-path logic is correct — the .clone() additions on document.metadata and document.document_id are necessary because document is now borrowed by ingest_document_into_memory_tree after the skill-store write; the error is mapped and logged without aborting; the None-config branch correctly skips tree ingest; and the blank-scope guard early-returns before forming an unreachable ":conn" scope. No new bugs introduced. (1 earlier finding(s) still open) The code index for this repository is cold, so this review saw the diff alone.
No findings.
Fixed since the last review
- Cover the tree-ingest failure path so log-and-continue cannot silently regress — fixed by the new
tree_ingest_failure_is_tolerated_and_skill_store_is_retainedtest, which forces a real ingest failure via a file-as-directory workspace, assertsingest_document_into_memory_treeerrors, assertsstorestill returnsOk, and asserts the skill store retains the document.