Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions optional-types.d.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
export interface Disposable {
// @ts-ignore -- Symbol.dispose might not be in user types
[Symbol.dispose]: () => void
}
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@
"module": "./dist/index.js",
"types": "./dist/index.d.ts",
"files": [
"dist"
"dist",
"optional-types.d.ts"
],
"engines": {
"node": ">=14.0.0"
Expand Down
5 changes: 4 additions & 1 deletion src/internal.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { assert, define, defineValue, isPromise, isType } from './utils.js'
import { SYMBOL_STATE } from './constants.js'
import type { Disposable } from '../optional-types.js'

interface GetState {
<A extends any[], R>(spy: SpyInternalImpl<A, R>): SpyInternalImplState<A, R>
Expand Down Expand Up @@ -67,7 +68,9 @@ export interface Spy<A extends any[] = any[], R = any>
nextResult(result: R): this
}

export interface SpyImpl<A extends any[] = any[], R = any> extends Spy<A, R> {
export interface SpyImpl<A extends any[] = any[], R = any>
extends Spy<A, R>,
Disposable {
getOriginal(): (...args: A) => R
willCall(cb: (...args: A) => R): this
restore(): void
Expand Down
3 changes: 3 additions & 0 deletions src/spyOn.ts
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,9 @@ export function spyOn<T extends object, K extends string & keyof T>(
;(['restore', 'getOriginal', 'willCall'] as const).forEach((method) => {
defineValue(spy, method, spy[SYMBOL_STATE][method])
})
if (Symbol.dispose) {
defineValue(spy, Symbol.dispose, spy[SYMBOL_STATE].restore)
}
return spy as any as SpyImpl
}

Expand Down
33 changes: 33 additions & 0 deletions test/index.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,39 @@ test('can spy on method', () => {
expect(method.results).toEqual([ok('a!'), ok('b!'), ok('C!'), error(err)])
})

test('restores mock on leaving a using scope', () => {
const obj = {
method: () => 'original',
}
const original = obj.method

{
using method = spyOn(obj, 'method').willCall(() => 'mocked')

expect(obj.method()).toBe('mocked')
expect(method.called).toBe(true)
}

expect(obj.method).toBe(original)
})

test('restores mock when a using scope throws', () => {
const obj = {
method: () => 'original',
}
const original = obj.method

expect(() => {
using method = spyOn(obj, 'method').willCall(() => 'mocked')

expect(obj.method()).toBe('mocked')
expect(method.called).toBe(true)
throw new Error('test')
}).toThrowError('test')

expect(obj.method).toBe(original)
})

test('resets all spies', () => {
let one = {
method(arg: string) {
Expand Down
1 change: 1 addition & 0 deletions tsup.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { defineConfig } from 'tsup'

export default defineConfig({
entryPoints: ['src/index.ts'],
external: ['../optional-types.js'],
outDir: 'dist',
format: ['esm'],
tsconfig: './tsconfig.json',
Expand Down
Loading