Conversation
MitchC1999
requested review from
a team,
ArvinJ-H,
HAFRMO,
TheSpyder,
jscasca,
kimwoodfield,
lorenzo-pomili,
ltrouton,
michalnieruchalski-tiugo,
shanmen-tiny and
spocke
and removed request for
a team
|
Decision has been made to archive this repo instead. |
There was a problem hiding this comment.
The table row and column toolbar menu buttons do not work, throws an error
TypeError: editor.plugins.table.getClipboardRows is not a function. (In 'editor.plugins.table.getClipboardRows()', 'editor.plugins.table.getClipboardRows' is undefined)
There was a problem hiding this comment.
Insert a templated row (drone status) do not work and throws an error
TypeError: editor.plugins.table.getClipboardRows is not a function. (In 'editor.plugins.table.getClipboardRows()', 'editor.plugins.table.getClipboardRows' is undefined)
There was a problem hiding this comment.
Would need a dev to advise on if this functionality is even possible with TinyMCE 8 for sure. I can't find a way to do it after looking at the table plugin's commands and APIs for a bit.
There was a problem hiding this comment.
I think it was an undocumented API, we replaced it with the "fake clipboard" concept (which doesn't have table-specific APIs but the table plugin uses it to store the same data).
tinymce-basics/useful_styles_for_content_css.html * Fixed invalid css * Re-added "hr" in the content * Removed `noneditable` plugin * Updated all documentation links tinymce-basics/badges.html * Removed `noneditable` plugin * Updated all documentation links tinymce-basics/custom-toolbar-button-menu-and-context-toolbar.html * Removed `noneditable` plugin * Updated all documentation links tinymce-basics/webapp-description-comment-reply-editor.html * Correctly use text pattern feature * Removed text pattern plugin * Updated all documentation links * Added markdown plugin tinymce-basics/bootstrap-rich-text-form.html * Updated all documentation links tinymce-basics/right-aligned-toolbar-button.html * Removed demo because we now have various badges showing up here tinymce-basics/format-link-as-button.html * Updated all documentation links tinymce-basics/fonts.html * Updated all documentation links * replaced font_formats with font_family_formats to make custom fonts show up images/toggle-image-size-context-toolbar.html * Updated all documentation links images/image-alt-text-context-form.html * Updated all documentation links tables/customizing-the-table-toolbar.html * Updated all documentation links * TODO: Commented out the cut/copy/paste row & column buttons preventing the menu from working, waiting for someone more talented to fix them using the new fake clipboard api: https://www.tiny.cloud/docs/tinymce/latest/apis/tinymce.fakeclipboard/ tables/table-row-templates.html * TODO: someone needs to update the copy paste row using the new fake clipboard api: https://www.tiny.cloud/docs/tinymce/latest/apis/tinymce.fakeclipboard/ otherwise the whole premise of the demo is gone * Updated all documentation links templates-and-layout/advanced-placeholder.html * Removed demo because the new enhanced templates plugin does not have the same features as the template plugin it replaced, and cannot be used with this demo, therefore the premise of the demo is lost. templates-and-layout/multiple-columns-using-css-columns.html * Removed demo because using css this way is not something TinyMCE supports very well, and I feel it is unwise to lead someone down this route. templates-and-layout/locked-down-template-inline-default.html * Updated all documentation links templates-and-layout/locked-down-template-inline-context-toolbars.html * Updated all documentation links templates-and-layout/locked-down-template-inline-context-toolbars.html * Updated all documentation links templates-and-layout/locked-down-template-inline-bordered.html * Updated all documentation links * Re-added the borderless skin to fix broken toolbar visuals email/webmail-rich-text-editor.html * Switched to naked skin because the outside skin had the editor outline on top of the bottom toolbar * Updated all documentation links email/marketing-email-inline-mode.html * Updated all documentation links email/marketing-email-inline-mode-fixed-toolbar.html * Updated all documentation links email/marketing-email.html * Updated the demo to use the mergetags plugin * Updated all documentation links cool-demos/expand-editor-and-show-toolbar.html * Fixed invalid CSS * Updated all documentation links * Note that toolbar bottom with the new tooltips makes it almost impossible to use the toolbar cool-demos/conditional-blocks.html * Updated all documentation links * Removed `noneditable` plugin cool-demos/slash-commands.html * Added the `tableofcontents` plugin * Updated all documentation links
| // TinyMCE 5.4 introduced improved APIs for inserting tables. | ||
| // TinyMCE has APIs for inserting tables. | ||
| // Here's a toolbar button that displays a table grid picker | ||
| // The table picker is unfortunately undocumented at this stage |
There was a problem hiding this comment.
Feels weird to just say this. Is this something we want to document? Looks like we don't document fancy menu items at all. "At this stage" implies that we might document it down the track...
There was a problem hiding this comment.
Alternatively - why do we have an "inserttable" menu item but not a toolbar button in TinyMCE? Should we add one?? Questions for outside the scope of this PR.
There was a problem hiding this comment.
It's a question that comes up occasionally from customers as well. I sometimes regret my inability to put us on a good architecture with TinyMCE 5 that would have made both work automatically.
There was a problem hiding this comment.
I left it as is. Can we simply add it to the docs?
There was a problem hiding this comment.
Probably worth documenting it at least, if customers are asking. I'll flag it with Karl
There was a problem hiding this comment.
Would need a dev to advise on if this functionality is even possible with TinyMCE 8 for sure. I can't find a way to do it after looking at the table plugin's commands and APIs for a bit.
…ng the old table clipboard apis are not for public consumption
8 participants
Update demos to TinyMCE 8