implement createTokenWithBankAccount #810
Conversation
| @@ -180,6 +180,28 @@ public static String getValue(final ReadableMap map, final String key) { | |||
| return allowedCountriesForShipping; | |||
| } | |||
|
|
|||
| public static BankAccountTokenParams.Type accountHolderTypeFromString(String value) { | |||
| if (value == "individual") { | |||
There was a problem hiding this comment.
In my case, this method always return null. So, I have to change from value == "individual" to value.equals("individual")
There was a problem hiding this comment.
Oh thank you for your review! 🙌 My Java is obviously pretty rusty, I'll try to push a commit with an .equals check as soon as possible!
There was a problem hiding this comment.
I pushed those changes you suggested, but wasn't able to test in the app I'm using this in myself because It doesn't build right now because of other reasons, and I'm on vacation for about a month so I don't have time to figure those details out right now. I trust that what you suggested is correct, but next time I'll be able to test to see that this is working myself is probably in the end of august, just an FYI.
Proposed changes
It addresses #809
createTokenWithBankAccountmisses the implementation for android, I suppose because thestripe-androidpackage changed token creation from using aBankAccounttoBankAccountTokenParamsso it broke this library at some point.This works as far as I've been able to see in the app I'm working on.
Types of changes
What types of changes does your code introduce to
tipsi-stripe?Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! Next steps are a reminder of what we are going to look at before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you choose the solution you did and what alternatives you considered.