Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Re-add card brand in Android Converter class #817

Closed
wants to merge 1 commit into from

Conversation

dsgraham
Copy link

Proposed changes

Card brand was removed from convertCardToWritableMap as the Stripe SDK nows returns a CardBrand object. This PR re-adds it, return the brand name as a string.

Types of changes

What types of changes does your code introduce to tipsi-stripe?
Put an x in the boxes that apply

  • Bugfix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! Next steps are a reminder of what we are going to look at before merging your code.

  • I have added tests that prove my fix is useful or that my feature works
  • I have added necessary documentation (if appropriate)
  • I know that my PR will be merged only if it has tests and they pass

Further comments

See issue #816

@fbartho fbartho closed this Jun 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants