This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
<Search /> #10
Open
<Search /> #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Title and descriptions styles
isnifer
suggested changes
Jan 31, 2017
| value={this.state.value} | ||
| placeholder='Search wine' | ||
| onChangeText={(text) => {setState({ value: text })}} | ||
| onClear={() => {setState({ value: '' })}} |
There was a problem hiding this comment.
please, provide the more complex example, that anyone can copy-paste and it will simply work: with parent component, it state, etc...
|
|
||
| const { driver, select, idFromXPath } = helper | ||
|
|
||
| test('<Expand />', async (t) => { |
There was a problem hiding this comment.
you need to rebase this branch against master
| onPress={() => { onRowClick(renderItem) }} | ||
| underlayColor={highlightColor}> | ||
| <View style={styles.row}> | ||
| <Text style={styles.suggestionText} numberOfLines={1}> {renderItem} </Text> |
| </TouchableOpacity> | ||
| ) | ||
| switch (clearButtonMode) { | ||
| case 'never': |
There was a problem hiding this comment.
Please add indent
switch (clearButtonMode) {
case 'never':| ...rest | ||
| } = this.props | ||
| let clearButton = ( | ||
| <TouchableOpacity style={styles.clearButtonWrapper} onPress={onClear} > |
|
|
||
| const items = suggestions.map(renderItem => | ||
| <TouchableHighlight | ||
| key={shortid.generate()} |
There was a problem hiding this comment.
I believe that this case has low performance
| </View> | ||
| { beforeSuggestionsRenderer } | ||
| {items.length > 0 && | ||
| <KeyboardAvoidingView behavior="height" style={{ flex: 1 }}> |
There was a problem hiding this comment.
all stylesheets should be in baseStyles
| /> | ||
| { clearButton } | ||
| </View> | ||
| { beforeSuggestionsRenderer } |
| </ScrollView> | ||
| </KeyboardAvoidingView> | ||
| } | ||
| { afterSuggestionsRenderer } |
|
I believe we should adopt some best practices from https://github.com/JedWatson/react-select |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.