Fixed mistake in JalDB.locate_operation().

Trades with no number are allowed.
titov-vv · May 24, 2024 · 98adcc0 · 98adcc0
1 parent b83564e
commit 98adcc0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/jal/db/db.py b/jal/db/db.py
@@ -374,7 +374,10 @@ def locate_operation(self, table_name, fields, data) -> int:
             return 0
         for field in validation_fields:
             if field not in data:
-                data[field] = fields[field]['default']   # set to default value
+                if 'default' in fields[field]:
+                    data[field] = fields[field]['default']   # set to default value
+                else:
+                    raise KeyError(f"Mandatory field '{field}' for table '{table_name}' is missing in {data} and have no default value")
             if data[field] is None:
                 query_text += f"{field} IS NULL AND "
             else:

diff --git a/jal/db/operations.py b/jal/db/operations.py
@@ -635,7 +635,7 @@ class Trade(LedgerTransaction):
     _db_fields = {
         "timestamp": {"mandatory": True, "validation": True},
         "settlement": {"mandatory": False, "validation": False},
-        "number": {"mandatory": False, "validation": True},
+        "number": {"mandatory": False, "validation": True, "default": ''},
         "account_id": {"mandatory": True, "validation": True},
         "asset_id": {"mandatory": True, "validation": True},
         "qty": {"mandatory": True, "validation": True},