Skip to content

change a few things for the PR #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
titusfortner wants to merge 1 commit into
base: temp_trunk2
Choose a base branch
from
Open

change a few things for the PR #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .bazelrc.remote
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ build:rbe --disk_cache=
build:rbe --incompatible_enable_cc_toolchain_resolution
build:rbe --action_env=BAZEL_DO_NOT_DETECT_CPP_TOOLCHAIN=1
test:rbe --test_env=DISPLAY=:99.0
test:rbe --test_tag_filters=-exclusive-if-local,-skip-rbe,-remote
test:rbe --test_tag_filters=-exclusive-if-local,-remote

# Env vars we can hard code
build:rbe --action_env=HOME=/home/dev
Expand Down
5 changes: 3 additions & 2 deletions cpp/iedriver/Alert.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@

#define INVALID_CONTROL_ID -1

// Changing this one for sure
namespace webdriver {

Alert::Alert(std::shared_ptr<DocumentHost> browser, HWND handle) {
Expand Down Expand Up @@ -81,7 +82,7 @@ int Alert::Accept() {
LOG(INFO) << "OK button does not exist on dialog; looking for Cancel button";
button_info = this->GetDialogButton(CANCEL);
}

if (!button_info.button_exists) {
LOG(WARN) << "OK and Cancel button do not exist on alert";
return EUNHANDLEDERROR;
Expand Down Expand Up @@ -239,7 +240,7 @@ std::string Alert::GetStandardDialogText() {
&Alert::FindTextLabel,
reinterpret_cast<LPARAM>(&info));
}

std::string alert_text_value;
if (info.label_handle == NULL) {
alert_text_value = "";
Expand Down
13 changes: 13 additions & 0 deletions java/test/org/openqa/selenium/bidi/input/DefaultKeyboardTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,19 @@ void testBasicKeyboardInput() {
shortWait.until(ExpectedConditions.attributeToBe(input, "value", "abc def"));
}

@Test
void testSomethingElse() {
driver.get(appServer.whereIs("single_text_input.html"));

WebElement input = driver.findElement(By.id("textInput"));

Actions sendLowercase = getBuilder(driver).sendKeys(input, "12345");

inputModule.perform(windowHandle, sendLowercase.getSequences());

shortWait.until(ExpectedConditions.attributeToBe(input, "value", "12345"));
}

@Test
@NotYetImplemented(SAFARI)
public void testSendingKeyDownOnly() {
Expand Down