Relax gem version requirement for unicode-display_width#139
Merged
nateberkopec merged 1 commit intotj:masterfrom Jan 27, 2025
Merged
Relax gem version requirement for unicode-display_width#139nateberkopec merged 1 commit intotj:masterfrom
unicode-display_width#139nateberkopec merged 1 commit intotj:masterfrom
Conversation
pboling
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
I need this change as well, because simplecov-console depends on this gem. Hopefully it can be released as a patch.
Worth noting that current release of rubocop has the following dependency on unicode-display_width
s.add_dependency('unicode-display_width', '>= 2.4.0', '< 4.0')
Does it make sense to match that, since it is going to be present in a majority of Gemfiles? Excluding v1 might prevent a patch release with a strict interpretation of SemVer though.
ref: https://github.com/rubocop/rubocop/blob/master/rubocop.gemspec#L42C1-L43C1
CC @nateberkopec @tj
|
Rubocop is now allowing unicode-display_width v3 This would fix an unexpected downgrade of - terminal-table (3.0.2)
- unicode-display_width (>= 1.1.1, < 3)
+ terminal-table (1.6.0)
thor (1.3.2)
tilt (2.5.0)
timeout (0.4.3)
@@ -721,7 +720,9 @@ GEM
ethon (>= 0.9.0)
tzinfo (2.0.6)
concurrent-ruby (~> 1.0)
- unicode-display_width (2.6.0)
+ unicode-display_width (3.1.3)
+ unicode-emoji (~> 4.0, >= 4.0.4)
+ unicode-emoji (4.0.4)
uniform_notifier (1.16.0) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #138
I think this is harmless ... bundled with 2.x version, specs passed; relaxed gemspec, bumped bundle, ran specs again ... seems ok?