Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion dds/_introspect_indirect.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
ExternalVarsVisitor,
LocalVar,
_function_name,
read_source,
)
from .structures import (
FunctionArgContext,
Expand Down Expand Up @@ -126,7 +127,7 @@ def _introspect_fun(
fiis_ = gctx.cached_indirect_interactions.get(fun_path)
if fiis_ is not None:
return fiis_
src = inspect.getsource(f)
src = read_source(f)
# _logger.debug(f"Starting _introspect: {f}: src={src}")
ast_src = ast.parse(src)
ast_f = ast_src.body[0] # type: ignore
Expand Down
16 changes: 13 additions & 3 deletions dds/introspect.py
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ def _introspect_class(
fis_ = gctx.cached_fun_interactions.get(fis_key)
if fis_ is not None:
return fis_
src = inspect.getsource(c)
src = read_source(c)
# _logger.debug(f"Starting _introspect_class: {c}: src={src}")
ast_src = ast.parse(src)
ast_f: ast.ClassDef = ast_src.body[0] # type: ignore
Expand Down Expand Up @@ -191,7 +191,7 @@ def _introspect_fun(
ast_f: Union[ast.Lambda, ast.FunctionDef]
if is_lambda(f):
# _logger.debug(f"_introspect: is_lambda: {f}")
src = inspect.getsource(f)
src = read_source(f)
h = dds_hash(src)
# Have a stable name for the lambda function
fun_path = CanonicalPath(
Expand All @@ -211,7 +211,7 @@ def _introspect_fun(
fis_ = gctx.cached_fun_interactions.get(fis_key)
if fis_ is not None:
return fis_
src = inspect.getsource(f)
src = read_source(f)
# _logger.debug(f"Starting _introspect: {f}: src={src}")
ast_src = ast.parse(src)
ast_f = ast_src.body[0] # type: ignore
Expand Down Expand Up @@ -882,6 +882,16 @@ def _build_return_sig(
return dds_hash_commut(all_pairs)


def read_source(f: Callable[..., Any]) -> str:
# For functions defined in test modules, the source code is directly
# attached to the function.
if "__dds_source" in dir(f):
src: str = f.__dds_source # type: ignore
return src
else:
return inspect.getsource(f)


_accepted_packages: Set[Package] = {
Package("dds"),
Package("__main__"),
Expand Down
128 changes: 128 additions & 0 deletions dds_tests/test_block_boundary.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,128 @@
import dds
import pytest
from .utils import cleandir, Counter

_ = cleandir

_var_function = {}


def _dummy():
pass


def _eval_function(s, function_name, dct):
global _var_function
_var_function["key"] = None
s2 = (
s
+ f"""

global _var_function
_var_function["key"] = {function_name}
"""
)
d = {"_var_function": _var_function, "dds": dds}
d.update(dct)
exec(s2, d)

f = _var_function["key"]
f.__dds_source = s
f.__module__ = _dummy.__module__
globals()[function_name] = f
return f


_c = Counter()


def f(i):
_ = i
_c.increment()
return 1


subsequent_change_s1 = """
def function():
i = 1
_ = dds.keep("/p", f, i)
# a
"""

subsequent_change_s2 = """
def function():
i = 1
_ = dds.keep("/p", f, i)
# b
"""


@pytest.mark.usefixtures("cleandir")
def test_subsequent_change():
fun = _eval_function(subsequent_change_s1, "function", {"f": f})
dds.eval(fun)
assert _c.value == 1
fun = _eval_function(subsequent_change_s2, "function", {"f": f})
dds.eval(fun)
assert _c.value == 2


next_line_change_s1 = """
def function():
i = 1
_ = dds.keep("/p", f, i)

# a
"""

next_line_change_s2 = """
def function():
i = 1
_ = dds.keep("/p", f, i)

# b
"""


@pytest.mark.usefixtures("cleandir")
def test_next_line_change():
_c.value = 0
fun = _eval_function(next_line_change_s1, "function", {"f": f})
dds.eval(fun)
assert _c.value == 1
fun = _eval_function(next_line_change_s2, "function", {"f": f})
dds.eval(fun)
assert _c.value == 1


subexpression_s1 = """
def function():
i = 1
_ = [
dds.keep("/p", f, i)
for x in range(3)
if x < 10
]
"""

subexpression_s2 = """
def function():
i = 1
_ = [
dds.keep("/p", f, i)
for x in range(3)
if x < 3 # change
]
"""


@pytest.mark.usefixtures("cleandir")
def test_subexpression():
_c.value = 0
fun = _eval_function(subexpression_s1, "function", {"f": f})
dds.eval(fun)
assert _c.value == 1
fun = _eval_function(subexpression_s2, "function", {"f": f})
dds.eval(fun)
# TODO: should be 2
assert _c.value == 1