Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Cloudflare SDK to latest version #40

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

elct9620
Copy link
Contributor

  • Upgrade Cloudflare SDK to v4
  • use panic directly in main.go to ensure error message is displayed
  • Add log message store endpoint in internal/ctrl/publish.go for check which endpoint (DNSRecord) is created

@elct9620 elct9620 force-pushed the feat/upgrade-cloudflare-sdk branch from 3f59003 to 954f7ee Compare September 19, 2024 14:01
Copy link
Owner

@tjjh89017 tjjh89017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tjjh89017 tjjh89017 merged commit 2bc9ffb into tjjh89017:main Sep 19, 2024
9 checks passed
@elct9620 elct9620 deleted the feat/upgrade-cloudflare-sdk branch September 19, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants