Skip to content

Commit

Permalink
Update version constraints for illuminate packages
Browse files Browse the repository at this point in the history
The requirements for the "illuminate/contracts" and "illuminate/support" packages have been updated in the composer.json file, specifying that any version greater than or equal to 10.0 is acceptable. This adjustment provides more flexibility in terms of package compatibility.

Daikazu patch 1 (#22)

* Update composer.json

* Fix styling

---------

Co-authored-by: daikazu <[email protected]>

Update Illuminate packages version constraints in composer.json
  • Loading branch information
daikazu committed May 7, 2024
1 parent c5ba2de commit f365d6b
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@
],
"require": {
"php": "^8.1",
"illuminate/contracts": "^10.0",
"illuminate/support": "^10.0",
"illuminate/contracts": "^10.0|^11.0",
"illuminate/support": "^10.0|^11.0",
"filament/filament": "^3.0",
"filament/forms": "^3.0",
"filament/tables": "^3.0",
Expand Down
2 changes: 1 addition & 1 deletion src/Models/GalleryImage.php
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ public function registerMediaCollections(): void
*
* @throws InvalidManipulation
*/
public function registerMediaConversions(Media $media = null): void
public function registerMediaConversions(?Media $media = null): void
{
// @phpstan-ignore-next-line
$this->addMediaConversion('thumb')
Expand Down
2 changes: 1 addition & 1 deletion tests/TestCase.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ protected function setUp(): void
parent::setUp();

Factory::guessFactoryNamesUsing(
fn (string $modelName) => 'Tjmpromos\\SortableGallery\\Database\\Factories\\' . class_basename($modelName) . 'Factory'
fn (string $modelName) => 'Tjmpromos\\SortableGallery\\Database\\Factories\\'.class_basename($modelName).'Factory'
);
}

Expand Down

0 comments on commit f365d6b

Please sign in to comment.