Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add py.typed #98

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add py.typed #98

wants to merge 2 commits into from

Conversation

eggplants
Copy link

@eggplants eggplants commented Jul 27, 2024

I added blank py.typed file into distribution package.

When I using pysub2 mypy raises the error because pysub2 does not PEP 561 typed marker file:

subt/main.py:7:1: error: Skipping analyzing "pysubs2": module is installed, but
missing library stubs or py.typed marker  [import-untyped]
    import pysubs2

pysubs2 type annotations are being checked with mypy --strict, so it can be available.

Copy link

codecov bot commented Jul 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.13%. Comparing base (dd3a891) to head (15fe96b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #98   +/-   ##
=======================================
  Coverage   93.13%   93.13%           
=======================================
  Files          36       36           
  Lines        2607     2607           
  Branches      449      449           
=======================================
  Hits         2428     2428           
  Misses        121      121           
  Partials       58       58           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eggplants
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant