Conversation
annieke
force-pushed
the
annie/release-automation
branch
3 times, most recently
from
a2781c9 to
a02c747
Compare
src/qos_host/Cargo.toml
Outdated
| version.workspace = true | ||
| edition.workspace = true | ||
| rust-version.workspace = true | ||
| publish = false | ||
| license.workspace = true | ||
| description = "QuorumOS enclave host that proxies requests to the enclave" | ||
| repository = "https://github.com/tkhq/qos" | ||
| keywords = ["quorumos", "enclave", "nitro", "proxy", "host"] |
There was a problem hiding this comment.
Is this a crate we expect users will consume externally? In mono we don't depend on it for example so I think the answer is no?
There was a problem hiding this comment.
In mono we don't depend on it for example so I think the answer is no?
Isn't that a model we want to move to though?
There was a problem hiding this comment.
I'm not sure we do, our code doesn't have a reason to depend on qos_host. But our infra does (we run qos_host as a container in enclave pods). So the solution is to publish container images from this repo (instead of rebuilding from mono).
There was a problem hiding this comment.
(and we are planning to publish container images as well, but that's not what this PR is about -- it will be a followup!)
There was a problem hiding this comment.
i'll remove qos_host as a crate and publish it as an image (which is what i'm doing for qos_enclave as well, no crate only image)
There was a problem hiding this comment.
Might be crazy, but the one reason to publish this would be so people could use cargo install to locally install the binary. However, I imagine this is not something we expect
There was a problem hiding this comment.
let's see if it's ever requested!
annieke
force-pushed
the
annie/release-automation
branch
from
a02c747 to
e642781
Compare
annieke
force-pushed
the
annie/release-automation
branch
from
e642781 to
7f7e397
Compare
annieke
force-pushed
the
annie/release-automation
branch
from
7f7e397 to
cb59ec5
Compare
.github/workflows/release-plz.yml
Outdated
| toolchain: stable | ||
| components: clippy,rustfmt | ||
| - name: Run release-plz | ||
| uses: release-plz/action@dde7b63054529c440305a924e5849c68318bcc9a #v0.5.107 |
There was a problem hiding this comment.
Let's bump this: I realized this morning that this version didn't support Trusted Publishing: tkhq/rust-sdk#88
| version.workspace = true | ||
| edition.workspace = true | ||
| rust-version.workspace = true | ||
| publish = false |
There was a problem hiding this comment.
let's bring publish = false back? (if we don't intend to publish it)
annieke
force-pushed
the
annie/release-automation
branch
from
cb59ec5 to
5a6675c
Compare
5 participants
Summary & Motivation (Problem vs. Solution)
We want to begin publishing QOS to crates.io. This PR adds release-plz, which will push new releases on closing PRs labeled with
release(same behavior as rust-sdk), and generate changelogs based on commits in that release.How I Tested These Changes
Has not been tested yet
Pre merge check list