This repository has been archived by the owner on Jul 13, 2019. It is now read-only.
Add options to change extensions to cli arguments and the CPPLINT.cfg option file #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
tkruse
force-pushed
the
add_extensions
branch
2 times, most recently
from
ebe2df0 to
7da0f37
Compare
| _valid_extensions = _valid_extensions.union(set(extensions)) | ||
| except ValueError: | ||
| sys.stderr.write('Extensions should be a comma-separated list of values;' | ||
| 'for example: extensions=hpp,cpp\n' |
There was a problem hiding this comment.
in the example, I'd write ','.join(_valid_extensions), so if (when) it's copy-pasted, it can be used as a starting point that gives the same behavior as the default behavior.
|
please also add information about the extensions option to the usage docstring (around line 150) |
|
I unified this PR with #11, as they deal with the same thing. will copy your comments there |
|
no, sorry, this one is the good PR, closed #11 |
tkruse
force-pushed
the
add_extensions
branch
2 times, most recently
from
25eec63 to
01c4e85
Compare
Closed
|
should not be merged before #22 |
Using flag name to --headers as it makes more sense Added the extensions option to the CPPLINT.cfg option file
tkruse
changed the title
|
now superceded by #22 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebasing this after #22 should remove several changes.
In addition to changes in #22, this should be extended to allow configuring:
as argument and as entry in cpplint.CFG. (not #18 and #21 also add configuration options)
As comment in #22 says, these options should take care to avoid User confusion over changing file extensions while keeping other fixed values for classification of headers and non-headers.