Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

who: update deprecated command #13222

Merged
merged 1 commit into from
Jul 7, 2024
Merged

who: update deprecated command #13222

merged 1 commit into from
Jul 7, 2024

Conversation

vanvuvuong
Copy link
Contributor

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@github-actions github-actions bot added page edit Changes to an existing page(s). translation Translate pages from one language to another. labels Jul 5, 2024
acuteenvy
acuteenvy reviewed Jul 5, 2024
View reviewed changes
Copy link
Member

@acuteenvy acuteenvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoami has its own separate page, because it's a different command. I think this example should be removed.

@spageektti
Copy link
Member

We can note about whoami in a See also line.

spageektti
spageektti previously requested changes Jul 6, 2024
View reviewed changes
Copy link
Member

@spageektti spageektti left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please make the changes @vanvuvuong ?

@vanvuvuong vanvuvuong force-pushed the main branch 2 times, most recently from 94038e4 to b1dd789 Compare July 7, 2024 02:27
@tldr-bot

This comment was marked as outdated.

Sign in to view
@tldr-bot

This comment was marked as resolved.

Sign in to view
@vanvuvuong
Copy link
Contributor Author

Can you please make the changes @vanvuvuong ?

Sure, I just updated, please review those changes.
The other See also translations I copied from corresponding language page.

sebastiaanspeck
sebastiaanspeck reviewed Jul 7, 2024
View reviewed changes
pages.nl/common/who.md Outdated Show resolved Hide resolved
pages.zh/common/who.md Outdated Show resolved Hide resolved
kbdharun
kbdharun approved these changes Jul 7, 2024
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution.

@kbdharun kbdharun merged commit 23f78e2 into tldr-pages:main Jul 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acuteenvy acuteenvy acuteenvy left review comments

@sebastiaanspeck sebastiaanspeck sebastiaanspeck approved these changes

@kbdharun kbdharun kbdharun approved these changes

@spageektti spageektti spageektti left review comments

Assignees
No one assigned
Labels
page edit Changes to an existing page(s). translation Translate pages from one language to another.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@vanvuvuong @spageektti @tldr-bot @sebastiaanspeck @kbdharun @acuteenvy