Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubectl-config: add page #13223

Merged
merged 1 commit into from
Jul 7, 2024
Merged

Conversation

vanvuvuong
Copy link
Contributor

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Jul 5, 2024
@tldr-bot
Copy link

tldr-bot commented Jul 5, 2024

The build for this PR failed with the following error(s):

pages/common/kubectl-config.md:3: TLDR004 Command descriptions should end in a period
pages/common/kubectl-config.md:4: TLDR004 Command descriptions should end in a period
pages/common/kubectl-config.md:5: TLDR004 Command descriptions should end in a period

Please fix the error(s) and push again.

pages/common/kubectl-config.md Outdated Show resolved Hide resolved
pages/common/kubectl-config.md Outdated Show resolved Hide resolved
@spageektti spageektti changed the title kubectl: add kubectl-config page kubectl-config: add page Jul 5, 2024
Copy link
Member

@gutjuri gutjuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for you contribution! I made some suggestions below :)

pages/common/kubectl-config.md Outdated Show resolved Hide resolved
pages/common/kubectl-config.md Outdated Show resolved Hide resolved
pages/common/kubectl-config.md Outdated Show resolved Hide resolved
pages/common/kubectl-config.md Outdated Show resolved Hide resolved
pages/common/kubectl-config.md Outdated Show resolved Hide resolved
pages/common/kubectl-config.md Outdated Show resolved Hide resolved
@vanvuvuong
Copy link
Contributor Author

Thank @gutjuri , I just updated all your suggestions.

@kbdharun
Copy link
Member

kbdharun commented Jul 7, 2024

LGTM, Thanks for your contribution.

@kbdharun kbdharun merged commit c779139 into tldr-pages:main Jul 7, 2024
4 checks passed
@spageektti spageektti removed their request for review July 16, 2024 22:09
@vanvuvuong vanvuvuong deleted the kubectl-config branch July 18, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants