-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubectl-config: add page #13223
Merged
Merged
kubectl-config: add page #13223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
new command
Issues requesting creation of a new page.
label
Jul 5, 2024
The build for this PR failed with the following error(s):
Please fix the error(s) and push again. |
vanvuvuong
force-pushed
the
kubectl-config
branch
from
July 5, 2024 02:56
4f85868
to
38a9445
Compare
vanvuvuong
force-pushed
the
kubectl-config
branch
from
July 5, 2024 08:48
38a9445
to
70135d5
Compare
gutjuri
reviewed
Jul 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for you contribution! I made some suggestions below :)
vanvuvuong
force-pushed
the
kubectl-config
branch
from
July 7, 2024 02:40
70135d5
to
7973456
Compare
Thank @gutjuri , I just updated all your suggestions. |
vanvuvuong
force-pushed
the
kubectl-config
branch
from
July 7, 2024 04:45
7973456
to
53d5e42
Compare
sebastiaanspeck
approved these changes
Jul 7, 2024
kbdharun
approved these changes
Jul 7, 2024
LGTM, Thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
common
,linux
,osx
,windows
,sunos
,android
, etc.