Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vagrant-box: add page #15650

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

vagrant-box: add page #15650

wants to merge 5 commits into from

Conversation

aminelch
Copy link

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The page(s) follow the style guide.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@CLAassistant
Copy link

CLAassistant commented Jan 31, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added new command Issues requesting creation of a new page or PRs adding a new page for a command. review needed Prioritized PRs marked for reviews from maintainers. labels Jan 31, 2025
@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/common/vagrant-box.md:8: TLDR014 Page should contain no trailing whitespace
pages/common/vagrant-box.md:12: TLDR014 Page should contain no trailing whitespace
pages/common/vagrant-box.md:16: TLDR014 Page should contain no trailing whitespace
pages/common/vagrant-box.md:20: TLDR014 Page should contain no trailing whitespace
pages/common/vagrant-box.md:23: TLDR104 Example descriptions should prefer infinitive tense (e.g. write) over present (e.g. writes) or gerund (e.g. writing)
pages/common/vagrant-box.md:24: TLDR014 Page should contain no trailing whitespace
pages/common/vagrant-box.md:28: TLDR014 Page should contain no trailing whitespace
pages/common/vagrant-box.md:31: TLDR104 Example descriptions should prefer infinitive tense (e.g. write) over present (e.g. writes) or gerund (e.g. writing)
pages/common/vagrant-box.md:32: TLDR014 Page should contain no trailing whitespace
pages/common/vagrant-box.md:36: TLDR014 Page should contain no trailing whitespace
pages/common/vagrant-box.md:38: TLDR008 File should contain no trailing whitespace

Please fix the error(s) and push again.

Copy link
Member

@gutjuri gutjuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have added some suggestions adding placeholders where appropriate

pages/common/vagrant-box.md Outdated Show resolved Hide resolved
pages/common/vagrant-box.md Outdated Show resolved Hide resolved
pages/common/vagrant-box.md Outdated Show resolved Hide resolved
pages/common/vagrant-box.md Outdated Show resolved Hide resolved
Co-authored-by: Managor <[email protected]>
Co-authored-by: Juri Dispan <[email protected]>
@aminelch aminelch requested review from gutjuri and Managor January 31, 2025 17:22
Copy link
Collaborator

@Managor Managor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go

Copy link
Collaborator

@MachiavelliII MachiavelliII left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command. review needed Prioritized PRs marked for reviews from maintainers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants