fix jagged sector rendering on iOS by using Path.arcTo() instead of Canvas.drawArc()
#153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ialGradient stops" This reverts commit 3552e3f.
…Canvas.drawArc()`
|
LGTM, but why this PR is closed? |
|
Honestly, I wasn’t entirely sure if this works. I’ve only been able to test it partially. Have you had a chance to verify whether this actually resolves the issue? If it does, I can go ahead and create a new PR with this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #151 by using
Path.arcTo()andcanvas.drawPath()instead ofcanvas.drawArc(), the sector now renders smoothly across both iOS and Android devices.