feat: supports reading config values from CLI #605
+70
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
you can the server with various options:
|
yuroitaki
requested changes
Sep 26, 2024
…es instead, removes validations in settings.rs
yuroitaki
requested changes
Sep 27, 2024
|
|
||
| tls: | ||
| enabled: true | ||
| private-key-pem-path: "./fixture/tls/notary.key" | ||
| certificate-pem-path: "./fixture/tls/notary.crt" | ||
| private_key_pem_path: "../fixture/tls/notary.key" |
There was a problem hiding this comment.
the path was correct, why did you change it?
There was a problem hiding this comment.
on my end the path didn't load, could you try with both relative paths on your end.
|
Sorry @yuroitaki I meant to refactor the commit, I've included the changes you've suggested :) . This commit will load the config.yaml and can also override with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR works on issue #604.
I using the config-rs library to combine the configs in the
main.rsfileI also set default values in the
settings.rsfile