[Synced PR #2146] feat(router): add notFound fallback — renders DefaultNotFound on unmatched routes (#2120) - #47
Open
tmdeveloper007 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream PR: Karanjot786/TermUI#2146
Original Author: divyanshim27
State: Closed ✗
Merge Commit SHA:
NoneLabels: type:docs, type:feature, stale, needs-star, area:data, type:testing
PR description:
Adds
notFoundconfig option to<Router>— rendersDefaultNotFound(or a custom component) when navigation targets an unregistered path,
instead of rendering nothing and freezing the terminal app.
Problem
When
navigate('/unregistered-path')was called,resolveRoute()returnednull and the Router rendered
null. In a terminal application, a null renderproduces a blank screen with no key inputs responding — the user has no way
to recover without killing the…
_