[Synced PR #1923] fix(ui): resolve TextArea wrapper imports and add tests - #51
Open
tmdeveloper007 wants to merge 1 commit into
Open
[Synced PR #1923] fix(ui): resolve TextArea wrapper imports and add tests#51tmdeveloper007 wants to merge 1 commit into
tmdeveloper007 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream PR: Karanjot786/TermUI#1923
Original Author: Harshithk951
State: Closed ✗
Merge Commit SHA:
NoneLabels: type:bug, stale, area:ui, type:testing
PR description:
This PR fixes missing imports (
useState,useInput,KeyEvent) in the functionalTextAreacomponent wrapper insidepackages/ui/src/components/TextArea.tsand changes its outer element fromtexttoboxto ensure children layout elements are reconciled properly. It also adds comprehensive unit tests.Related Issue
Closes Karanjot786#1921
Which package(s)?
@termuijs/ui
Type of Change
type:bug)type:feature)_