Skip to content

Use COMBINING MACRON for \bar #884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tmke8 merged 1 commit into from
Mar 15, 2026
Merged

Use COMBINING MACRON for \bar #884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/math-core/src/commands.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ static COMMANDS: phf::Map<&'static str, Token> = phf::phf_map! {
"." => TextMode(TextToken::Accent(symbol::COMBINING_DOT_ABOVE.as_op().as_char())),
":" => MathOrTextMode(&Space(LatexUnit::Mu.length_with_unit(4.0)), '\u{205F}'),
";" => MathOrTextMode(&Space(LatexUnit::Mu.length_with_unit(5.0)), '\u{2004}'),
"=" => TextMode(TextToken::Accent(symbol::COMBINING_OVERLINE)),
"=" => TextMode(TextToken::Accent(symbol::COMBINING_OVERLINE.as_op().as_char())),
">" => MathOrTextMode(&Space(LatexUnit::Mu.length_with_unit(4.0)), '\u{205F}'),
"AA" => TextMode(TextToken::Letter('Å')),
"AE" => TextMode(TextToken::Letter('Æ')),
Expand Down Expand Up @@ -142,7 +142,7 @@ static COMMANDS: phf::Map<&'static str, Token> = phf::phf_map! {
"backsimeq" => Relation(symbol::REVERSED_TILDE_EQUALS),
"backslash" => Ord(symbol::REVERSE_SOLIDUS),
"backtrprime" => Ord(symbol::REVERSED_TRIPLE_PRIME),
"bar" => Accent(symbol::LOW_LINE, true, OpAttrs::STRETCHY_FALSE),
"bar" => Accent(symbol::COMBINING_MACRON, true, OpAttrs::empty()),
"barwedge" => BinaryOp(symbol::NAND),
"bcancel" => Enclose(Notation::DOWN_DIAGONAL),
"because" => Relation(symbol::BECAUSE),
Expand Down
2 changes: 1 addition & 1 deletion crates/math-core/tests/snapshots/wiki_test__wiki007.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,6 @@ expression: "\\check{a}, \\breve{a}, \\tilde{a}, \\bar{a}"
<mo>,</mo>
<mover accent="true">
<mi>a</mi>
<mo stretchy="false">_</mo>
<mo>̄</mo>
</mover>
</math>
2 changes: 1 addition & 1 deletion crates/math-core/tests/snapshots/wiki_test__wiki112.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ expression: "\\hat a \\ \\bar b \\ \\vec c \\\\ \\overrightarrow{a b} \\ \\overl
<mtext> </mtext>
<mover accent="true">
<mi>b</mi>
<mo stretchy="false">_</mo>
<mo>̄</mo>
</mover>
<mtext> </mtext>
<mover accent="true">
Expand Down
4 changes: 2 additions & 2 deletions crates/math-core/tests/snapshots/wiki_test__wiki212.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ expression: "|\\bar{z}| = |z|, |(\\bar{z})^n| = |z|^n, \\arg(z^n) = n \\arg(z)"
<mo stretchy="false" lspace="0" rspace="0">|</mo>
<mover accent="true">
<mi>z</mi>
<mo stretchy="false">_</mo>
<mo>̄</mo>
</mover>
<mo stretchy="false" lspace="0" rspace="0">|</mo>
<mo>=</mo>
Expand All @@ -18,7 +18,7 @@ expression: "|\\bar{z}| = |z|, |(\\bar{z})^n| = |z|^n, \\arg(z^n) = n \\arg(z)"
<mo stretchy="false">(</mo>
<mover accent="true">
<mi>z</mi>
<mo stretchy="false">_</mo>
<mo>̄</mo>
</mover>
<msup>
<mo stretchy="false">)</mo>
Expand Down
4 changes: 2 additions & 2 deletions crates/mathml-renderer/src/symbol.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,8 +363,8 @@ pub const COMBINING_GRAVE_ACCENT: Rel = Rel::new('\u{300}', RelCategory::Default
pub const COMBINING_ACUTE_ACCENT: Rel = Rel::new('\u{301}', RelCategory::Default);
pub const COMBINING_CIRCUMFLEX_ACCENT: Rel = Rel::new('\u{302}', RelCategory::Default);
pub const COMBINING_TILDE: Rel = Rel::new('\u{303}', RelCategory::Default);
// pub const COMBINING_MACRON: char = '\u{304}';
pub const COMBINING_OVERLINE: char = '\u{305}';
pub const COMBINING_MACRON: Rel = Rel::new('\u{304}', RelCategory::Default);
pub const COMBINING_OVERLINE: Rel = Rel::new('\u{305}', RelCategory::Default);
pub const COMBINING_BREVE: Rel = Rel::new('\u{306}', RelCategory::Default);
pub const COMBINING_DOT_ABOVE: Rel = Rel::new('\u{307}', RelCategory::Default);
pub const COMBINING_DIAERESIS: Rel = Rel::new('\u{308}', RelCategory::Default);
Expand Down
Binary file modified playground/LibertinusMath-Regular.woff2
View file
Open in desktop
Binary file not shown.
Binary file modified playground/NewCMMath-Book-prime-roundhand-vec.woff2
View file
Open in desktop
Binary file not shown.
Binary file modified playground/NotoSansMath-Regular-centered-diacritics-primes.woff2
View file
Open in desktop
Binary file not shown.
8 changes: 4 additions & 4 deletions playground/experiments.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,18 +158,18 @@ <h1>Experiments</h1>
</math>
<tr>
<td>
Macron, stretchy=false
COMBINING MACRON, stretchy=false
<td>
<math display="block">
<mover accent="true">
<mi>x</mi>
<mo stretchy="false">¯</mo>
<mo stretchy="false">&#x304;</mo>
</mover>
</math>
</tr>
<tr>
<td>
Macron, stretchy=true
COMBINING MACRON
<td>
<math display="block">
<mover accent="true">
Expand All @@ -178,7 +178,7 @@ <h1>Experiments</h1>
<mi>y</mi>
<mi>z</mi>
</mrow>
<mo stretchy="true">¯</mo>
<mo>&#x304;</mo>
</mover>
</math>
</tr>
Expand Down
2 changes: 1 addition & 1 deletion playground/test.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
<math display="block">
<mover accent="true">
<mi>x</mi>
<mo stretchy="false">_</mo>
<mo>̄</mo>
</mover>
<mo>,</mo>
<mover accent="true">
Expand Down
Loading