Skip to content

Standardize all predefined searches to use Ctrl #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

m1foley
Copy link

@m1foley m1foley commented Apr 6, 2017

Reasons:

  • The Alt key is inconvenient/confusing for most OS X users. Alt is not enabled by default so it needs to be specifically remapped in a terminal application.
  • Consistency is better. It's easier to remember the search keys if they all use Ctrl.

Why the Alt mappings exist:

  • I assume there was a good reason to use Alt when the IP address search was added, but the commit message doesn't mention what it was.
  • The SHA-1 search was originally changed from Ctrl to Alt because prefix + C-h conflicts with tmux-pain-control. C-s doesn't work either because it sends the XOFF signal, so changing this will require an awkward letter. I went with "a" because it's the vowel in both "SHA" and "hash".

Backwards compatibility with the old mappings should be added as well, but I'd like to hear your thoughts on this PR before writing more code.

- The Alt key is inconvenient/confusing for most OS X users. The Apple
  key layout doesn't enable Alt by default so it needs to be
  specifically remapped in a terminal application.
- Consistency is better. It's easier to remember the search keys if they
  all use Ctrl.
@nguyenj
Copy link

nguyenj commented Apr 27, 2017

Until this gets merged, here's my work around

# .tmux.conf

# set this before the plugin
set -g @copycat_has_search 'C-a'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants