Skip to content

Fix oidcc-prompt-login match pattern to handle variable query parameter ordering - #1

Draft
tnorimat with Copilot wants to merge 1 commit into
mainfrom
copilot/fix-issue-1020
Draft

Fix oidcc-prompt-login match pattern to handle variable query parameter ordering#1
tnorimat with Copilot wants to merge 1 commit into
mainfrom
copilot/fix-issue-1020

Conversation

Copilot AI commented Jun 7, 2026 •
edited
Loading

Copy link
Copy Markdown

The oidcc-prompt-login test fails with conformance suite v5.1.43 because the match pattern assumes prompt=login is the last query parameter.

The conformance suite uses PatternMatchUtils.simpleMatch() (Spring) which requires the pattern to match the entire string. The pattern auth*prompt=login won't match when additional parameters follow:

https://…/auth?client_id=…&nonce=…&prompt=login&redirect_uri=…&response_mode=…
                                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                                               not matched — no trailing wildcard

The max_age pattern already handled this correctly with auth*max_age=*.

  • Added trailing * to the prompt=login match pattern across all 18 oidcc-*-automated.json configs:
- "match": "https://as.keycloak-fapi.org/auth/realms/test/protocol/openid-connect/auth*prompt=login"
+ "match": "https://as.keycloak-fapi.org/auth/realms/test/protocol/openid-connect/auth*prompt=login*"

fix: add trailing wildcard to oidcc-prompt-login match patterns
adf3068 
The match pattern `auth*prompt=login` requires the URL to end with
`prompt=login`, but newer conformance suite versions may place
`prompt=login` in the middle of query parameters rather than at the
end. Adding a trailing `*` (`auth*prompt=login*`) ensures the pattern
matches regardless of query parameter ordering.

Fixes: keycloak#1020
Copilot AI changed the title fix: add trailing wildcard to oidcc-prompt-login match patterns Fix oidcc-prompt-login match pattern to handle variable query parameter ordering Jun 7, 2026
Copilot AI requested a review from tnorimat June 7, 2026 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tnorimat tnorimat Awaiting requested review from tnorimat

Assignees

@tnorimat tnorimat

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tnorimat